Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomacs: 3.17.2295 -> 3.19.0 #325977

Merged
merged 1 commit into from
Jul 11, 2024
Merged

nomacs: 3.17.2295 -> 3.19.0 #325977

merged 1 commit into from
Jul 11, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/nomacs/versions.

meta.description for nomacs is: Qt-based image viewer

meta.homepage for nomacs is: https://nomacs.org

meta.changelog for nomacs is: https://github.com/nomacs/nomacs/releases/tag/3.19.0

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.19.0 with grep in /nix/store/c7xcxaszk3j218j52rncii67akdsmkds-nomacs-3.19.0
  • found 3.19.0 in filename of file in /nix/store/c7xcxaszk3j218j52rncii67akdsmkds-nomacs-3.19.0

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

nomacs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/c7xcxaszk3j218j52rncii67akdsmkds-nomacs-3.19.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nomacs https://github.com/r-ryantm/nixpkgs/archive/71448bf2147464c004ed1d38181ab6edd2ad5019.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/71448bf2147464c004ed1d38181ab6edd2ad5019#nomacs

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/c7xcxaszk3j218j52rncii67akdsmkds-nomacs-3.19.0
ls -la /nix/store/c7xcxaszk3j218j52rncii67akdsmkds-nomacs-3.19.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • nomacs
  • nomacs.man

Maintainer pings

cc @AndersonTorres @Mindavi for testing.

@Mindavi
Copy link
Contributor

Mindavi commented Jul 10, 2024

For x86_64-linux, seems to work fine:

Result of nixpkgs-review pr 325977 run on x86_64-linux 1

2 packages built:
  • nomacs
  • nomacs.man

Also tried starting it and viewing a few images. Didn't test any other functionality. Let's wait a bit for darwin since we've seen it break before and I don't have a way to verify darwin functionality.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting ofBorg

@Mindavi
Copy link
Contributor

Mindavi commented Jul 11, 2024

Unlikely it will finish any time soon, let's just go for it.

@Mindavi Mindavi merged commit 11e58c3 into NixOS:master Jul 11, 2024
29 of 30 checks passed
@r-ryantm r-ryantm deleted the auto-update/nomacs branch July 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants